Skip to content

Conversation

@zingale
Copy link
Member

@zingale zingale commented Oct 22, 2025

No description provided.

@zingale
Copy link
Member Author

zingale commented Oct 22, 2025

@zingale
Copy link
Member Author

zingale commented Oct 25, 2025

this actually results in a 1% slowdown on Frontier (for flame_wave)

@zingale zingale marked this pull request as draft October 25, 2025 16:33
@zingale
Copy link
Member Author

zingale commented Oct 25, 2025

groot GPU tests: http://groot.astro.sunysb.edu/Microphysics/test-suite/gpu/2025-10-25-001/index.html

it seems like this can make a small diff in some cases with CUDA.

On Frontier, it is less clear.

@zingale
Copy link
Member Author

zingale commented Oct 28, 2025

changing the type of the pivot array makes things worse. If I remove that, the remainder of the changes are mostly just making things const.

@zingale
Copy link
Member Author

zingale commented Nov 1, 2025

this still causes answer diffs on Frontier. Not sure where the issue is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant